Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow Numeric for iat field on OIDC tokens #4518

Merged
merged 2 commits into from Dec 17, 2020
Merged

allow Numeric for iat field on OIDC tokens #4518

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00e379
allow Numeric for iat field on OIDC tokens
mitchellhenke Dec 17, 2020
202b887
update OIDC iat error translations
mitchellhenke Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/openid_connect_token_form.rb
View file
Open in desktop
Expand Up @@ -128,7 +128,7 @@ def validate_aud_claim(payload)
def validate_iat(payload)
return true unless payload.key?('iat')
iat = payload['iat']
return true if iat.is_a?(Integer) && (iat.to_i - ISSUED_AT_LEEWAY_SECONDS) < Time.zone.now.to_i
return true if iat.is_a?(Numeric) && (iat.to_i - ISSUED_AT_LEEWAY_SECONDS) < Time.zone.now.to_i

errors.add(:client_assertion, t('openid_connect.token.errors.invalid_iat'))
end
Expand Down