Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-width to list items, remove bottom margin. #55

Merged
merged 1 commit into from Feb 12, 2019
Merged

Conversation

adunkman
Copy link
Member

@adunkman adunkman commented Feb 7, 2019

Fixes #54.

Two list tweaks:

  1. Adds a max-width to list items.
  2. Removes the bottom margin from <ul> and <ol> elements when they are the last item in a container, to prevent excess bottom space (see screenshot).

Additionally, it adds lists to the Typography documentation page, so we can observe the changes:

Before After
Screenshot of list items which do not have maximum width constraints and have extra margin-bottom Screenshot of list items which are constrained by a maximum width, and do not contain extra margin-bottom

When a UL or OL is the last item in a container, drop its bottom margin.
@adunkman
Copy link
Member Author

adunkman commented Feb 7, 2019

@nickttng Tagged you for a review here, since it sounds like you’ll be looking after this repo going forward, but let me know if I’m mistaken!

Copy link
Member

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Also, thumb up on the removal of excess bottom margin. Good eye.

@adunkman adunkman merged commit dcb0291 into master Feb 12, 2019
@adunkman adunkman deleted the li-max-width branch February 12, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants