Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use USWDS icons with badge component #442

Merged
merged 1 commit into from
May 7, 2024
Merged

Use USWDS icons with badge component #442

merged 1 commit into from
May 7, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented May 7, 2024

馃洜 Summary of changes

Updates Badge component to use USWDS icons.

This works toward removing our custom alert icons.

Related: #439, #441

馃摐 Testing Plan

  1. Run locally as npm start
  2. Go to http://localhost:4000/badges/
  3. Observe badge icons

馃憖 Screenshots

Before After
before after

Copy link
Member

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll create a follow-up ticket to update the Figma library version for this, and the validation messages in #441.

@aduth
Copy link
Member Author

aduth commented May 7, 2024

Visual regression failure is expected due to icon and markup changes:

image

@aduth aduth merged commit 87081ec into main May 7, 2024
3 of 4 checks passed
@aduth aduth deleted the aduth-badge-icons branch May 7, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants