Update Puppeteer, remove resize handling in visual regression specs #438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃洜 Summary of changes
This pull request:
The intent is to try to resolve inconsistencies observed in visual regression failures in #437:
fillImageToSize
helper doesn't work as intended, since it will only fill pixels which are missing outside both the expected width and height, but not either lacking height nor lacking width.main
running an older version of Puppeteer can cause the failure to re-emerge. Performing the upgrade in a separate pull request allows the update to be made tomain
independent of the changes in Use frame for sandboxed component preview, stricter accessibility checks聽#437.馃摐 Testing Plan
Build should pass.