Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Utiliser la nouvelle version LTS de node 16.14. #4176

Merged
merged 5 commits into from
Mar 9, 2022

Conversation

VincentHardouin
Copy link
Member

@VincentHardouin VincentHardouin commented Mar 8, 2022

🦄 Problème

La dernière version LTS de node est la 16.14

🤖 Solution

Voir 1024pix.atlassian.net/wiki/spaces/DEV/pages/1549434939/Mises+jour+hors+npm#Node

🌈 Remarques

Utilisation des nouvelles images cimg à la place de circleci
Celles-ci ne contiennent plus Chrome et Firefox par défaut, pour remédier à cela il faut utiliser un orbs comme c'est expliqué dans le guide de migration.

Un warning est présent pour les apps Ember, mais la CI d'ember inclut Node 16

Cette PR remplace la #3638

💯 Pour tester

Vérifier que la CI passe

@VincentHardouin VincentHardouin self-assigned this Mar 8, 2022
@pix-service
Copy link
Contributor

Copy link
Contributor

@xav-car xav-car left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VincentHardouin VincentHardouin force-pushed the tech-bump-node-lts-14.17-to-16.14 branch from a001938 to 6782821 Compare March 8, 2022 15:33
@matthiasferraina
Copy link
Contributor

Testé sur mon-pix et sur l'api. All Good ✅

@octo-topi octo-topi linked an issue Mar 9, 2022 that may be closed by this pull request
@pix-service-auto-merge pix-service-auto-merge merged commit b23d82e into dev Mar 9, 2022
@pix-service-auto-merge pix-service-auto-merge deleted the tech-bump-node-lts-14.17-to-16.14 branch March 9, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node n'est pas à la dernière version LTS
7 participants