-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Utiliser la nouvelle version LTS de node 16.14. #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm deploying this PR to these urls:
Please check it out! |
VincentHardouin
force-pushed
the
tech-bump-node-lts-14.17-to-16.14
branch
from
March 8, 2022 10:44
cde42e6
to
85c4a9b
Compare
VincentHardouin
force-pushed
the
tech-bump-node-lts-14.17-to-16.14
branch
from
March 8, 2022 12:51
2debac1
to
a001938
Compare
xav-car
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
VincentHardouin
force-pushed
the
tech-bump-node-lts-14.17-to-16.14
branch
from
March 8, 2022 15:33
a001938
to
6782821
Compare
alexandrecoin
approved these changes
Mar 8, 2022
Testé sur mon-pix et sur l'api. All Good ✅ |
matthiasferraina
approved these changes
Mar 9, 2022
octo-topi
approved these changes
Mar 9, 2022
VincentHardouin
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
Mar 9, 2022
pix-service-auto-merge
force-pushed
the
tech-bump-node-lts-14.17-to-16.14
branch
from
March 9, 2022 08:28
6782821
to
0c14ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
La dernière version LTS de node est la 16.14
🤖 Solution
Voir 1024pix.atlassian.net/wiki/spaces/DEV/pages/1549434939/Mises+jour+hors+npm#Node
🌈 Remarques
Utilisation des nouvelles images cimg à la place de circleci
Celles-ci ne contiennent plus Chrome et Firefox par défaut, pour remédier à cela il faut utiliser un
orbs
comme c'est expliqué dans le guide de migration.Un warning est présent pour les apps Ember, mais la CI d'ember inclut Node 16
Cette PR remplace la #3638
💯 Pour tester
Vérifier que la CI passe