Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] ✨ Upgrade storybook to v7.1.0 #445

Merged
merged 46 commits into from Jul 25, 2023
Merged

Conversation

mickaelalibert
Copy link
Contributor

@mickaelalibert mickaelalibert commented Jul 24, 2023

🎄 Problème

Nous utilisons la version 6 de storybook. Storybook 6 est incompatible avec node 18. Nous devons donc passer a storybook 7 pour être compatible node 18.

🎁 Solution

  1. Galérer pas mal pour réparer l'intégration ember de storybook: Ember: Fix @storybook/ember storybookjs/storybook#23435
  2. Publier un package @1024pix/storybook-ember qui inclut les modifications de storybook ember
  3. Migrer ce dépot vers storybook 7
  4. Migrer les stories: https://storybook.js.org/docs/ember/migration-guide

🎅 Pour tester

  1. Naviger sur la RA et voir les différents composants

@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr445.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-ui-review-pr445/environment

@yannbertrand yannbertrand changed the title ✨ Upgrade storybook to v7.1.0 [BREAKING] ✨ Upgrade storybook to v7.1.0 Jul 25, 2023
@yannbertrand yannbertrand changed the title [BREAKING] ✨ Upgrade storybook to v7.1.0 [FEATURE] ✨ Upgrade storybook to v7.1.0 Jul 25, 2023
Copy link
Contributor

@francois2metz francois2metz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌹 🌺 💮 🥀 🌷 🌻 🌸 LGTM 🌸 🌻 🌷 🥀 💮 🌺 🌹

@github-actions github-actions bot merged commit 8c88a08 into dev Jul 25, 2023
8 checks passed
@github-actions github-actions bot deleted the storybook7-pour-de-vrai branch July 25, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants