-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] ✨ Upgrade storybook to v7.1.0 #445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr445.review.pix.fr |
francois2metz
force-pushed
the
storybook7-pour-de-vrai
branch
from
July 24, 2023 12:46
41a5438
to
152d07e
Compare
mariannebost
force-pushed
the
storybook7-pour-de-vrai
branch
from
July 24, 2023 14:00
a5fd13b
to
18f5fa9
Compare
francois2metz
force-pushed
the
storybook7-pour-de-vrai
branch
from
July 25, 2023 08:23
c210867
to
eddaf55
Compare
yannbertrand
changed the title
✨ Upgrade storybook to v7.1.0
[BREAKING] ✨ Upgrade storybook to v7.1.0
Jul 25, 2023
yannbertrand
changed the title
[BREAKING] ✨ Upgrade storybook to v7.1.0
[FEATURE] ✨ Upgrade storybook to v7.1.0
Jul 25, 2023
francois2metz
force-pushed
the
storybook7-pour-de-vrai
branch
from
July 25, 2023 08:29
eddaf55
to
8897a4d
Compare
francois2metz
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌹 🌺 💮 🥀 🌷 🌻 🌸 LGTM 🌸 🌻 🌷 🥀 💮 🌺 🌹
mariannebost
approved these changes
Jul 25, 2023
yannbertrand
approved these changes
Jul 25, 2023
mickaelalibert
added
🚀 Ready to Merge
Tech review OK
and removed
👀 Tech Review Needed
labels
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Nous utilisons la version 6 de storybook. Storybook 6 est incompatible avec node 18. Nous devons donc passer a storybook 7 pour être compatible node 18.
🎁 Solution
🎅 Pour tester