Use the Jsonrpc types as the abstraction layer in the store interfaces #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
changed the title
b00ris
reviewed
Nov 9, 2022
|
|
||
| // GetHeaderByNumber returns the header by number | ||
| GetHeaderByNumber(block uint64) (*types.Header, bool) | ||
| Header() *Block |
There was a problem hiding this comment.
Why does header function return block? =)
There was a problem hiding this comment.
Yes, the name should be changed. The idea is that for the jsonrpc module there is no difference between Block and Header. Thus, we should return only jsonrpc.Block. The name has to change too.
There was a problem hiding this comment.
Now that I think about it, Header is not a good name either for what it does. It should be LatestHeader or something like that.
| @@ -821,13 +675,13 @@ func (e *Eth) Unsubscribe(id string) (bool, error) { | |||
| return e.filterManager.Uninstall(id), nil | |||
| } | |||
|
|
|||
| func (e *Eth) getBlockHeader(number BlockNumber) (*types.Header, error) { | |||
| func (e *Eth) getBlockHeader(number BlockNumber) (*Block, error) { | |||
ferranbt
force-pushed
the
ferranbt-experimental-jsonrpc-abstract-types
branch
from
f73adfc
to
0bce5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the types from the
jsonrpcpackage on the abstraction interface.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it