Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature rootchain dev clique #1000

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

ferranbt
Copy link
Contributor

@ferranbt ferranbt commented Dec 5, 2022

Description

This PR replaces the consensus protocol of the debug rootchain server and uses Clique instead of the Dev mode. This is necessary if we want to enable premined accounts in a custom genesis file, which is not possible in Dev.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@ferranbt ferranbt changed the base branch from develop to feature/v3-parity December 5, 2022 18:29
"alloc": { {{range $key, $value := .Allocs}}
"{{ $key }}": {"balance": "{{ $value }}"}{{end}}
},
"extradata": "0x0000000000000000000000000000000000000000000000000000000000000000{{.ValidatorAddr}}0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the format of the extraData field required by Clique.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@16463dd). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity    #1000   +/-   ##
====================================================
  Coverage                     ?   55.27%           
====================================================
  Files                        ?      167           
  Lines                        ?    22440           
  Branches                     ?        0           
====================================================
  Hits                         ?    12404           
  Misses                       ?     9055           
  Partials                     ?      981           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0xPolygon 0xPolygon deleted a comment from CLAassistant Jan 9, 2023
Base automatically changed from feature/v3-parity to develop February 6, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants