Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update file name checker to account for space issue #111

Merged
merged 2 commits into from
Apr 14, 2023
Merged

fix: update file name checker to account for space issue #111

merged 2 commits into from
Apr 14, 2023

Conversation

LangLangBart
Copy link
Contributor

Description

@andy5995
Copy link
Member

@LangLangBart You now have admin privileges. I'll step aside and you can consider yourself the primary admin if you like.

@LangLangBart LangLangBart merged commit b1e9688 into 0ad-matters:master Apr 14, 2023
3 checks passed
@LangLangBart
Copy link
Contributor Author


  • Commit access makes it easier to fix trivial problems

@andy5995
Copy link
Member

  • is the bullseye something you have to provide? the workflow runs slow.

    * I would just use the checkout method from [checkrefs.yml: (fix) check for non-empty file #108](https://github.com/0ad-matters/community-maps-2/pull/108) instead.
    
    • Commit access makes it easier to fix trivial problems

bullseye is a self-hosted runner I run on my computer in a docker container (which means workflows won't run when my computer is off), but at this point, I'm sure you'll agree it would make more sense to switch back to a standard GitHub runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants