Split out metadata uploading from ReceivableService.createReceivableWithMetadata #12
Conversation
|
| REACT_APP_ALCHEMY_API_KEY_2= |
There was a problem hiding this comment.
Maybe we can name the alchemy api key by chain?
There was a problem hiding this comment.
I'll eventually need to take a second pass on all the examples and move them into the huma-sdk repo directory, so I'll take this as a TODO until then
| `Using ${walletOnRWRNetwork.address} to create RealWorldReceivable` | ||
| ); | ||
|
|
||
| // Prefund Bundlr with MATIC |
There was a problem hiding this comment.
Can we delete this part as it's commented? Or it will be used later?
There was a problem hiding this comment.
They can prefund on the first try. I will uncomment it.
| @@ -305,11 +338,12 @@ describe('declareReceivablePaymentByReferenceId', () => { | |||
|
|
|||
| describe('declareReceivablePaymentByTokenId', () => { | |||
| beforeEach(() => { | |||
| jest.clearAllMocks() | |||
| jest.restoreAllMocks() | |||
There was a problem hiding this comment.
Question: why restoreAllMocks?
There was a problem hiding this comment.
clearAllMocks wasn't properly resetting the mocked functions in between tests. Seems like a known issue jestjs/jest#7136
We need to enable our Celo partners to mint RWR with metadata. Because Celo is unsupported by Bundlr, I'm splitting out the metadata upload function to allow partners to optionally pay for their metadata upload on different networks.