Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PackageLicenseExpression on nuget #544

Closed
thompson-tomo opened this issue Apr 5, 2024 · 5 comments
Closed

Set PackageLicenseExpression on nuget #544

thompson-tomo opened this issue Apr 5, 2024 · 5 comments
Assignees

Comments

@thompson-tomo
Copy link

thompson-tomo commented Apr 5, 2024

Summary

I wish for the nuget packages to have the licence expression property set correctly

Details

The licence expression property should be set to the correct licence type (depending on the repo) as this will enable analysis of licences in use to occur in external tools & the license type will be shown in Nuget etc.

@JonathanMagnan JonathanMagnan self-assigned this Apr 6, 2024
@JonathanMagnan
Copy link
Member

Hello @thompson-tomo

I'm not sure what you are trying to say, the current license on NuGet currently points to this URL: https://github.com/zzzprojects/html-agility-pack/blob/master/LICENSE

Let me know more about your concerns.

Best Regards,

Jon

@thompson-tomo
Copy link
Author

@JonathanMagnan i am using cyclonedx to generate SBOM's of all the libraries i am using and checking licence compliance which leverages the licence expression being set. Also by having it set it becomes easiliy visible in nuget.org

@JonathanMagnan
Copy link
Member

Oh ok, I understand @thompson-tomo ,

It will be done the next time we release HAP

Best Regards,

Jon

@JonathanMagnan
Copy link
Member

Hello @thompson-tomo ,

A new version is now available.

I don't really like it, as we now point to a generic page: https://licenses.nuget.org/MIT instead of the license that include the information, but oh well, since it looks like all majors packages I verified are doing it, I guess we will just stay like this.

Let me know if everything now works on your side.

Best Regards,

Jon

@thompson-tomo
Copy link
Author

Looks good so will close issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants