Method not found: 'Int32 HtmlAgilityPack.HtmlNode.GetAttributeValue (binary breaking change)

[ronaldbarendse]

Description

After upgrading from 1.11.18 to 1.11.19 (or 1.11.20) the following exception is thrown, because this method is removed for some targets:

html-agility-pack/src/HtmlAgilityPack.Shared/HtmlNode.cs

Lines 1316 to 1324 in 8d89711

	#if METRO || NETSTANDARD1_3 || NETSTANDARD1_6
	/// <summary>
	/// Helper method to get the value of an attribute of this node. If the attribute is not found, the default value will be returned.
	/// </summary>
	/// <param name="name">The name of the attribute to get. May not be <c>null</c>.</param>
	/// <param name="def">The default value to return if not found.</param>
	/// <returns>The value of the attribute if found, the default value if not found.</returns>
	public int GetAttributeValue(string name, int def)
	{

This is a binary breaking change, as libraries using this method will need to be recompiled against this version to work again.

Exception

Exception message: Method not found: 'Int32 HtmlAgilityPack.HtmlNode.GetAttributeValue(System.String, Int32)'.
Stack trace: System.MissingMethodException

Further technical details

• NET version (net472, netcore, etc.): net472

[JonathanMagnan]

Hello @ronaldbarendse ,

Yes, you are right.

I will ask my developer to restore those methods and explain to him why he never removes one unless we release a major.

Best Regards,

Jon

---

Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework Extensions • Entity Framework Classic • Bulk Operations • Dapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval Function • SQL Eval Function

[ronaldbarendse]

These kind of breaking changes are always hard to track, as you would expect it to automatically use the generic method in this case... 😉 And it does without changing the consuming libraries code, but it still requires a recompile, because the binary/IL code will be different.

Adding the methods back for these targets as stubs that call the generic version should be an easy fix 👍 The next major version could then remove these methods again.

[JonathanMagnan]

Yup exactly ;)

The v1.11.21 is now released.

Let me know if your project is now working correctly

[ronaldbarendse]

Thanks, this patch has fixed the issue 👍