New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HtmlNode.InnerText Not working properly (JS get Working normally) maybe a bug? #317
Comments
Hello @AtlantisDe , Thank you for reporting, we will look at it. Best Regards, Jonathan Performance Libraries Runtime Evaluation |
Hello @AtlantisDe , The v1.11.10 has been released. Could you try it and let me know if this issue is correctly fixed on your side. |
Just a note that something broke for me in 1.11.10 related to InnerText. Code:
That returns the expected text for the page title when run in 1.11.9, but an empty string in 1.11.10. 1.11.10 now puts the title in InnerHtml instead. |
thanks now is ok |
yes here can get var title_1 = htmlDocument.DocumentNode.Element("html").Element("head").Element("title").InnerHtml; that's a broken var title_2 = htmlDocument.DocumentNode.Element("html").Element("head").Element("title").InnerText; |
I can confirm what @Kinematics said above, 1.11.10 has fatal regression regarding |
I removed the latest version from NuGet. I will get it fixed on Monday. Best Regards, Jonathan |
Hello all, The v1.11.11 has been released. Now only Let me know if that version is working as expected. |
Working normally Thank you very much.... |
Apologies for replying to a closed issue. I've just updated to 1.11.11 and been bitten by this change with several tests failing, specifically in regards to the I tested opening a page in Firefox where a Next I tested another page which had JavaScript and doing I think therefore that potentially the new implementation is still flawed, at least in regards to I tested this in Firefox 68. Don't know if this is useful information or not, but I'm going to revert back to 1.11.8 until I know if I really need to start examining Thanks; |
Hello @cyotek , Thank you for reporting, It looks you somewhat are right. The text in the We will look at it this week and try to have it work as the browser does. |
@JonathanMagnan I've tried latest 1.11.11 and it suffers from the same issue as .10. In particular, I'm doing Maybe I'm doing something wrong or don't understand an issue, but this used to work until now. Let me know if you need some reproducible case, but I'm pretty sure this will happen with any |
Hello All, The v1.11.12 has been released.
It fixes your issue @JustArchi , @cyotek However, if we get some more error reported, we might just rollback all these changes or add an option to have the current behavior since this kind of change currently break some code which is not something we really love to do. Let me know if everything now works as expected. |
I'm not any less confused than I was before, but I can confirm that 1.11.12 works again for my use cases, thank you 😅. |
Hello, I just updated to 1.11.12 and can confirm non of my tests have failed so all seems to be well regarding the new build. Hopefully it also addresses the OP's issue too! Thanks again for the fast response and fix. Regards; |
Likewise confirming that 1.11.12 is working fine for me. |
Hello All,i will close it...if u have any issue..pls reopen... |
Description
The Html source : https://auto.qq.com/a/20120202/000205.htm
YOU can use this code test
Exception (HtmlAgilityPack.HtmlNode.innertext) like this img
Google Chrome console Js get is OK
Js Get
pls help me
The text was updated successfully, but these errors were encountered: