Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization doesn't support html encoding #316

Closed
omrycarmel opened this issue Jul 16, 2019 · 8 comments
Closed

Serialization doesn't support html encoding #316

omrycarmel opened this issue Jul 16, 2019 · 8 comments
Assignees

Comments

@omrycarmel
Copy link

omrycarmel commented Jul 16, 2019

Description:
Loading a serialized HTML document that has html encoding in it - builts the DOM differently.
This is because the serialized string reflects the decoded HTML.

I've added a code with test function that you can use.
.Net version: 4.7.2, HAP version: latest

Edit:
I removed the fiddle link because fiddle decoded the html decoding string in the code.
I've sent code sample to:
info@zzzprojects.com

Thanks

@JonathanMagnan JonathanMagnan self-assigned this Jul 16, 2019
@JonathanMagnan
Copy link
Member

Hello @omrycarmel ,

Thank you for the Fiddle (not compiling is not a problem as long as we have the code to reproduce it).

We will look at it.

Best Regards,

Jonathan


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

@JonathanMagnan
Copy link
Member

Hello @omrycarmel ,

The v1.11.10 has been released.

Could you try it and let me know if this issue is correctly fixed on your side.

@omrycarmel
Copy link
Author

I dont see any change in the behaviour,
The test function that I sent you still fail.
Does it work for you?

@JonathanMagnan
Copy link
Member

Hello @omrycarmel ,

Unfortunately, we had to hide the version with your fix due to a mistake of our part (on another fix). That's why you didn't see your fix when you tried it.

The v1.11.11 has been released, could you try it?

@omrycarmel
Copy link
Author

Thanks for the quick responses,

I just updated to 1.11.11 and the test program that I sent still doesn't work

@JonathanMagnan
Copy link
Member

Hello @omrycarmel ,

What exactly doesn't work? It seems to work fine on our side, see here: https://dotnetfiddle.net/wPvGol

@JonathanMagnan
Copy link
Member

JonathanMagnan commented Jul 24, 2019

I also tried the one you provided by email directly in visual studio, it also return true.

@omrycarmel
Copy link
Author

Sorry, my mistake, it works :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants