Missing parse from binary literal to integer

[RafaelEnriquez]

ExpressionParser parses from hexadecimal literal to integer, but is missing a parse from binary literal to integer.

https://dotnetfiddle.net/cTfqh7

Exception

[StefH]

#554

[StefH]

Hello @RafaelEnriquez ;

I think the linked PR should solve this, if you have time, can you take a look?

[RafaelEnriquez]

Hi @StefH , thanks for your work on this.

I was expecting the fix to be something like the existing code for hexadecimal in "ExpressionParser.ParseIntegerLiteral".

Does this PR makes the provided fiddle test pass???

Regards

[StefH]

Hello @RafaelEnriquez,

I did move some code from ExpressionParser.ParseIntegerLiteral to a new file and also added some more tests for that new code.

See
https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/stef-binary/test/System.Linq.Dynamic.Core.Tests/Parser/NumberParserTests.cs#L137

(I think this covers your scenario, but if you have questions or want to add more test, please let me know)

[StefH]

Hello @RafaelEnriquez, did you have time to check if the unit-test is enough for your scenario?

[RafaelEnriquez]

Hi @StefH . Yes, the tests you added are enough.

Thank you very much.