New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BulkMerge(Async) with IncludeGraphOperationBuilder IgnoreOnMergeUpdate not being honored #797
Comments
Hello @tsanton , Thank you for reporting. My developer will look into it tomorrow morning. Best Regards, Jon |
Hello @tsanton , Thank you again for reporting. We currently have the right behavior for SQL Server but indeed as you reported, it looks like we have a bug with We will look more and try to fix it. Best Regards, Jon |
Many thanks @JonathanMagnan! Hope to hear back from you here when the issue is closed or a resolution timeline exist :) Have a great weekend when that time comes; speak soon! /T |
Hello @tsanton , A new version has been deployed today. Could you try it and confirm us that the issue has been fixed correctly? Best Regards, Jon |
Hi @JonathanMagnan! Just tested it and I can confirm that the Just for giggles I tried the inverse: My issue is solved, but I don't think that the config is behaving exactly as expected. I still would like to say many thanks for the expedience you show in regard to replying, following up, solving issues! /T |
Hello @tsanton , My bad, I forgot to tell you that the option So, from what I understand, you would like an option I will ask my developer to look at it. Unfortunately, it will not be available before the end of May as we are currently pausing release for 3 weeks during my vacation. Best Regards, Jon |
@JonathanMagnan I see, copy that! As of right now this isn't a blocker/issue as I do think this leans towards the "nice to have" side, rather than "must have". In my opinion it would enhance the package simply because it turns Merge into a powerhouse, capable of any constellation of UpdateInsert(Delete?) for any and all entities. In combination with transactions it certainly lets me execute complex operations with high fidelity. What I would suggest, in combination with this implementation, is to enhance the Merge documentation with examples where a complex Insert/Update case much like my scenario above with multiple child entities is well described with config in code and behaviour output as SQL. The functionality of your Merge is second to none, but I do think it's difficult for people without "hardcore" SQL-backgrounds to fully grasp how powerful, functional and flexible the method is. I'll leave you guys be for the next three weeks then and get back to bothering you come June :) Enjoy your vacation! /T |
I 100% agree with you. That's something I will make sure it happens. I do not believe it will be really hard on our side but surely ask us a few changes.
Thank ;) I will sure do!!! |
1. Description
I'm having some issues with the IncludeGraphOperationBuilder.
I have a parent with three children, where I want to upsert the parent, upsert child1, insert child2 and conditionally insert child3.
In short my merge config looks as such:
Here is what I want to achieve:
As of now the
IgnoreOnMergeUpdate
is not being honored. I still see the UPDATE statements generated for UA and US. I know I can achieve the desired outcome by justIgnoreOnMergeUpdateExpression
all properties in the entity, but I am somewhat hoping for an easier fix by simply ignoring the update (making it a flat conditional insert) for the sake of performance.Haven't tested the other way around, but I would hope
InsertIfNotExists = false
would remove the insert part in cases where you only want updates but not inserts in a somewhat complex setup.Further technical details
The text was updated successfully, but these errors were encountered: