Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to render UUIDs as a :slug, A slug is a URL safe Ba… #31

Merged
merged 5 commits into from Nov 7, 2018
Merged

Added the ability to render UUIDs as a :slug, A slug is a URL safe Ba… #31

merged 5 commits into from Nov 7, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2018

I have been working on an application that uses the elixir-uuid library and I have written my own code to handle slug conversion. I thought I would put it in this library as another format that the user could get a UUID in and thus make use of it.

Added the ability to render UUIDs as a :slug, A slug is a URL safe Base 64 encoded UUID with the padded == stripped which can be used on a URL.

rsimmons added 2 commits May 28, 2018 03:16
…se 64 encoded UUID with the padded == stripped which can be used on a URL.
@ghost
Copy link
Author

ghost commented Jun 7, 2018

Is this repository being maintained anymore?

@zyro
Copy link
Owner

zyro commented Jun 7, 2018

@kraythen It is, but I have very limited time to spend on it - I'll go through this PR as soon as I can. Until then looks like Travis is complaining, any ideas why?

@ghost
Copy link
Author

ghost commented Jun 9, 2018

No idea on the complaints, it builds and runs and tests fine. If you want I can help you maintain.

@ghost
Copy link
Author

ghost commented Aug 3, 2018

Any chance of getting this merged?

@zyro
Copy link
Owner

zyro commented Aug 22, 2018

As soon as I can find a spare moment to figure out the CI failure this PR introduces.

@ghost
Copy link
Author

ghost commented Sep 22, 2018

Greetings, any chance of this getting added ?

@ghost
Copy link
Author

ghost commented Oct 22, 2018

Any update on integrating this change ? Is this lib active ?

@ghost
Copy link
Author

ghost commented Oct 22, 2018

ping again ?

@zyro
Copy link
Owner

zyro commented Oct 22, 2018

@kraythen Yes I'm still maintaining this as best I can, but I haven't had time to look into the CI failure yet.

@ghost
Copy link
Author

ghost commented Oct 23, 2018

the CI build is running on 1.3.4 and failing tests.

@ghost
Copy link
Author

ghost commented Oct 23, 2018

I have fixed the CI problems. The Elixir version and OTP version were the problem. Can we get a merge and publish?

@zyro
Copy link
Owner

zyro commented Oct 23, 2018

Nothing I can see from the changes would require a version bump straight to Elixir 1.7. What am I missing?

@ghost
Copy link
Author

ghost commented Oct 23, 2018

I dont know why but before this build the code had "codepoint" invalid character failures on characters that werent even there. Bumping the elixir version fixed it. Question would be is if there is any reason to NOT bump the elixir version. If so then we have to find the right version above 1.3 where it works but not too high.

@zyro
Copy link
Owner

zyro commented Nov 7, 2018

Ideally I want to target the lowest version possible to ensure this is as widely usable as possible. I'll merge as is and experiment with lower versions at some point before I tag a new version.

@zyro zyro merged commit 81b1004 into zyro:master Nov 7, 2018
@zyro
Copy link
Owner

zyro commented Nov 7, 2018

@kraythen Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant