Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csharp code doesn't support string interpolating #17265

Closed
FateOri opened this issue Feb 10, 2021 · 12 comments
Closed

Csharp code doesn't support string interpolating #17265

FateOri opened this issue Feb 10, 2021 · 12 comments

Comments

@FateOri
Copy link

FateOri commented Feb 10, 2021

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/tokens/interpolated

$ symbol displays as invalid in a red box.

@andersk
Copy link
Member

andersk commented Feb 10, 2021

Upstream issue: pygments/pygments#1573

@zulipbot
Copy link
Member

Hello @zulip/server-dependencies, @zulip/server-markdown members, this issue was labeled with the "area: dependencies", "area: markdown" labels, so you may want to check it out!

@timabbott
Copy link
Sponsor Member

Thanks for the report! The right path forward for this is for someone to submit a PR to pygments upstream, and then we can upgrade once they've merged and released the fix.

@ashantilong
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Welcome to Zulip, @ashantilong! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@ashantilong
Copy link
Collaborator

I claimed this issue: #17265 which states C sharp code doesn't support string interpolating and I was wondering where the code is provided so I can recreate and fix it. Can anyone point me to the right direction ?

@ashantilong
Copy link
Collaborator

@FateOri

@FateOri
Copy link
Author

FateOri commented Feb 18, 2021

@FateOri

well you have to check upstream repo and fix it there first

string interpolation is a common feature so you can take the idea how to fix it from other PL that already has support for it

for example,

pygments/pygments@627123c#diff-8b5d7b3e3c7991140b596cfcdb0ee4f1c6afd56e4133f6974a908a455ccbcb01

@FateOri
Copy link
Author

FateOri commented Feb 18, 2021

@ashantilong

@ashantilong
Copy link
Collaborator

Thank you @FateOri I was able to find it and am working on the process now with the pygment lib now

@andersk
Copy link
Member

andersk commented Mar 2, 2021

@ashantilong Pygments is an upstream project with different maintainers and different development processes. The zulipbot “claim” comment that you just sent to the upstream issue isn’t going to do anything but confuse those maintainers. You’ll need to figure out how that project works and follow its rules.

@ashantilong ashantilong removed their assignment Mar 6, 2021
@timabbott
Copy link
Sponsor Member

I'm going to close this issue for Zulip; while we'd like to see it fixed, it's tracked upstream in pygments (and tagged as a good first issue there) and not significant enough for Zulip to need independent tracking of it. (We'll automatically get the fix when we next upgrade pygments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants