Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set queue on accessibility announcements in OfflineNoticeProvider #5611

Open
gnprice opened this issue Dec 13, 2022 · 2 comments · May be fixed by #5644 or dashwave-test/zulip-mobile#15
Open

Set queue on accessibility announcements in OfflineNoticeProvider #5611

gnprice opened this issue Dec 13, 2022 · 2 comments · May be fixed by #5644 or dashwave-test/zulip-mobile#15
Assignees
@1010nishant
Labels
a-a11y Accessibility help wanted

Comments

@gnprice
Copy link
Member

gnprice commented Dec 13, 2022 •
edited

This is a followup to #5344 (once that upgrade is done, as in #5610.) We have the following TODO-react-native comments in OfflineNoticeProvider.js:

      // TODO(react-native-68): Use announceForAccessibilityWithOptions to
      //   queue this behind any in-progress announcements
      AccessibilityInfo.announceForAccessibility(_('Zulip’s Internet connection is uncertain.'));
// …
      // TODO(react-native-68): Use announceForAccessibilityWithOptions to
      //   queue this behind any in-progress announcements
      AccessibilityInfo.announceForAccessibility(_('Zulip is online.'));

That's referring to this new feature in RN v0.68:
https://reactnative.dev/docs/0.68/AccessibilityInfo#announceforaccessibilitywithoptions

By default announcements will interrupt any existing speech, but on iOS they can be queued behind existing speech by setting queue to true in the options object.

That would be a nice, small, polish tweak.
@gnprice gnprice added the a-a11y Accessibility label Dec 13, 2022
@gnprice gnprice mentioned this issue Dec 13, 2022
Closed
@hetpatel4902
Copy link

Can i take this issue? i am a beginner..., i have done the mobile app setup.

@1010nishant
Copy link

So far what I have understood about the issue is that we need to replace announceForAccessibility method with announceForAccessibilityWithOptions method.
I would like to work on this issue could you please assign me.

@1010nishant 1010nishant mentioned this issue Jan 21, 2023
Closed
1010nishant added a commit to 1010nishant/zulip-mobile that referenced this issue Jan 23, 2023
@1010nishant
Fix:announcements by the screen reader interrupt any existing speech
569f7a1 
TODO comment:Use announceForAccessibilityWithOptions to queue this behind
any in-progress announcements

fixes: zulip#5611
1010nishant added a commit to 1010nishant/zulip-mobile that referenced this issue Jan 23, 2023
@1010nishant
Fix:announcements by the screen reader interrupt any existing speech
5c4236d 
TODO comment:Use announceForAccessibilityWithOptions to queue this behind
any in-progress announcements

fixes: zulip#5611
@1010nishant 1010nishant linked a pull request Jan 23, 2023 that will close this issue
Open
1010nishant added a commit to 1010nishant/zulip-mobile that referenced this issue Jan 23, 2023
@1010nishant
Fix:announcements by the screen reader interrupt any existing speech
964ab78 
TODO comment:Use announceForAccessibilityWithOptions to queue this behind
any in-progress announcements

By default announcements will interrupt any existing speech, but they can be queued
behind existing speech by setting queue to true in the second parameter of
announceForAccessibilityWithOptions method as it takes an object.

i have replaced announceForAccessibility() with announceForAccessibilityWithOptions().

fixes: zulip#5611
1010nishant added a commit to 1010nishant/zulip-mobile that referenced this issue Jan 25, 2023
@1010nishant
offline notice: Queue non-urgent a11y announcements behind in-progress
de56346 
ones
fixes: zulip#5611
@supra08 supra08 linked a pull request May 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1010nishant 1010nishant

Labels
a-a11y Accessibility help wanted
Projects
None yet
Milestone
No milestone
4 participants
@gnprice @chrisbobbe @hetpatel4902 @1010nishant