Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #31: stop using the deprecated "extension" way of registering events. #34

Merged
merged 2 commits into from Oct 16, 2019

Conversation

ctheune
Copy link
Contributor

@ctheune ctheune commented Oct 12, 2019

No description provided.

Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a zope.sqlalchemy that works with modern sqlalchemy, so let's merge this.

src/zope/sqlalchemy/datamanager.py Outdated Show resolved Hide resolved
src/zope/sqlalchemy/datamanager.py Outdated Show resolved Hide resolved
src/zope/sqlalchemy/tests.py Show resolved Hide resolved
@icemac
Copy link
Member

icemac commented Oct 16, 2019

@ctheune As the PR is approved, feel free to merge it. I can cut a release afterwards.

@icemac
Copy link
Member

icemac commented Oct 16, 2019

Maybe the suggestions of @mgedmin should be included before the merge. 😄

…ter()

Update set([]) to -> {} syntax as suggested by mgedmin.
@ctheune ctheune merged commit 0ebebea into master Oct 16, 2019
@ctheune ctheune deleted the ctheune-fix-event-registration branch October 16, 2019 06:49
@icemac
Copy link
Member

icemac commented Oct 17, 2019

Released as 1.2 to PyPI, see https://pypi.org/project/zope.sqlalchemy/1.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants