Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filenames with spaces don't render correctly on GitHub pages #73

Open
jcolson opened this issue Jan 17, 2022 · 4 comments
Open

Filenames with spaces don't render correctly on GitHub pages #73

jcolson opened this issue Jan 17, 2022 · 4 comments

Comments

@jcolson
Copy link

jcolson commented Jan 17, 2022

filenames with spaces are converted to links with %20 in them, however kramdown/etc does not seem to properly recognize this and does not convert these links to proper html links, instead it keeps the .md extention, which fails to work (404) on github pages.

EDIT: I tested manually replacing the %20 with an actual space, and github's kramdown now renders it properly. (maybe this could be an option, as %20 "should" work (in my opinion) everywhere, github just has an issue maybe?)

@zoni
Copy link
Owner

zoni commented Jan 17, 2022

It would not be too difficult to offer different "link encoding profiles" optimized for different markdown engines, with the current set being the default.

If you let me know which characters should, and which should not, be encoded to play nice with Kramdown/Jekyll, I'd be happy to implement this.

@zoni
Copy link
Owner

zoni commented Jan 17, 2022

Also, was this on Jekyll/GitHub pages, or just GitHub's rendering of Markdown files when you browse a repository?
Is the behavior different or the same for those?

@zoni zoni changed the title filenames with spaces Filenames with spaces don't render correctly on GitHub pages Jan 17, 2022
@jcolson
Copy link
Author

jcolson commented Jan 17, 2022

It would not be too difficult to offer different "link encoding profiles" optimized for different markdown engines, with the current set being the default.

If you let me know which characters should, and which should not, be encoded to play nice with Kramdown/Jekyll, I'd be happy to implement this.

the only thing i ran into was the %20 ... which, remarkably, I didn't see too much consternation about from users; my google skills may be lacking.

@jcolson
Copy link
Author

jcolson commented Jan 17, 2022

Also, was this on Jekyll/GitHub pages, or just GitHub's rendering of Markdown files when you browse a repository? Is the behavior different or the same for those?

specifically github pages ... i haven't tried standard github rendering of the results of an export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants