Make copyTransactionsFrom much faster in history-free storages when possible #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage. Increases the copy rate from 1.01MB/s to 5.58MB/s on a sample of transactions, or 180000 objects to 417000 objects. Outstanding issues: zodbconvert's incremental mode doesnt work. zc.zlibstorage doesn't work on the destination during the copy. Maybe that's ok. Because you could just not use a decompressing wrapper on the source to get identical copies. Logging is messed up.
…ations when using incremental zodbconvert. This is still not fully safe, though: If you start copying, stop, start again in incremental mode, because one copies by OID and the other by TID you could wind up missing data. Needs more thought.
Add tests with blobs, more incremental testing, and tests with history-free destinations. This found, and added a workaround for, zopefoundation/ZODB#330
We'll manually transform the data there, allowing us to replace the wrappers copyTransactionsFrom method with our own optimized implementation in registerDB.
…unate) interaction betwenn incremental copies and fast copies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
record_iternextand only copying current objects. The big win comes from batching up the transaction commits. The speed increase seems to be at least 5x or more.Disabled with the
--incrementaloption of zodbconvert; see updated documenattion.There are additional tests to make sure blobs are copied, and for the handling of storage wrappers like zc.zlibstorage.
Fixes #425