Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop check-manifest dependencies from pre-commit #17

Closed
zobayer1 opened this issue Sep 16, 2021 · 0 comments · Fixed by #18
Closed

Drop check-manifest dependencies from pre-commit #17

zobayer1 opened this issue Sep 16, 2021 · 0 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@zobayer1
Copy link
Owner

When used with `setuptools-scm > 6.0.1, check-manifest incorrectly extracts version from sdist filename.

Possible fixes:

  1. Drop check-manifest from pre-commit.
  2. Use locally built check-manifest manually from zobayer1/check-manifest/tree/fix_145 which contains a fix (pending PR Fix for extracting version incorrectly from sdist filename containing dashes mgedmin/check-manifest#146)
  3. Discussion on the issue setuptools scm workaround doesnt work for packages with dashes in the name mgedmin/check-manifest#145
@zobayer1 zobayer1 added the bug Something isn't working label Sep 16, 2021
@zobayer1 zobayer1 mentioned this issue Sep 16, 2021
Merged
zobayer1 added a commit that referenced this issue Sep 16, 2021
@zobayer1
Merge pull request #18 from zobayer1/buildfix
a8fe542 
Remove version pinning and remove dependency on check-manifest
Closes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove version pinning and remove dependency on check-manifest zobayer1/logging-extras
1 participant
@zobayer1