From 9289dd3cba62201c723e6f2c864de605c8770297 Mon Sep 17 00:00:00 2001 From: Chris Barker Date: Mon, 28 Dec 2020 09:39:40 -0800 Subject: [PATCH 1/2] Rephrase confusing comment in descriptors.js --- packages/core-js/internals/descriptors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core-js/internals/descriptors.js b/packages/core-js/internals/descriptors.js index 2673a79994e9..60767760a7f1 100644 --- a/packages/core-js/internals/descriptors.js +++ b/packages/core-js/internals/descriptors.js @@ -1,6 +1,6 @@ var fails = require('../internals/fails'); -// Thank's IE8 for his funny defineProperty +// Handle IE8's unusual defineProperty implementation module.exports = !fails(function () { return Object.defineProperty({}, 1, { get: function () { return 7; } })[1] != 7; }); From 3a4e1cc56584e64dcdc1ec430b916bf226c0635a Mon Sep 17 00:00:00 2001 From: Chris Barker Date: Mon, 28 Dec 2020 10:40:49 -0800 Subject: [PATCH 2/2] comment --- packages/core-js/internals/descriptors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core-js/internals/descriptors.js b/packages/core-js/internals/descriptors.js index 60767760a7f1..2880a96d98cf 100644 --- a/packages/core-js/internals/descriptors.js +++ b/packages/core-js/internals/descriptors.js @@ -1,6 +1,6 @@ var fails = require('../internals/fails'); -// Handle IE8's unusual defineProperty implementation +// Detect IE8's incomplete defineProperty implementation module.exports = !fails(function () { return Object.defineProperty({}, 1, { get: function () { return 7; } })[1] != 7; });