Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for rhino JS engine #942

Merged
merged 1 commit into from Jun 10, 2021
Merged

Conversation

gausie
Copy link
Contributor

@gausie gausie commented Jun 10, 2021

To get this running on the current version of Rhino I needed to:

  • Change GLOBAL in tests.js to equal global
  • Replace console.log with print
  • Return false for "es.string.search" because the code causes an NPE

These (in particular number 3) are good little tasks to fix upstream in Rhino though

Then it ran no problem with java -jar rhino.jar -version 200 -require ./node-runner.js

@zloirock
Copy link
Owner

Thanks -)

@zloirock
Copy link
Owner

zloirock commented Jun 10, 2021

The question: what means flag here http://mozilla.github.io/rhino/compat/engines.html?

(never mind - found the answer)

@gausie
Copy link
Contributor Author

gausie commented Jun 10, 2021

It means running it with the es6 flag - its misleading because its not a pre-release flag, its a flag that the docs recommend everyone set when working with Rhino.

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants