Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-js-builder): change blacklist term #882

Merged
merged 1 commit into from Nov 24, 2020

Conversation

rivajunior
Copy link

blacklist is racial offensive and can easely be changed by other terms as exclude or denylist.

I've choose exclude because I think it fits better than denylist in this context. But I can change it.

@zloirock
Copy link
Owner

zloirock commented Nov 9, 2020

I don't think that blacklist is racial offensive - I can't imagine what kind of complexes a person should have in order to be offended by this. However, yes, for this case exclude sounds better and I could accept this PR. But it's a breaking change, so required a fallback to blacklist.

README.md Outdated Show resolved Hide resolved
@rivajunior rivajunior force-pushed the refactor/change-blacklist-term branch from a9343bb to aae7671 Compare November 9, 2020 14:03
@rivajunior rivajunior force-pushed the refactor/change-blacklist-term branch from aae7671 to bbf0280 Compare November 9, 2020 14:05
README.md Show resolved Hide resolved
@zloirock zloirock merged commit e3b7484 into zloirock:master Nov 24, 2020
zloirock added a commit that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants