Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ie11 Out of stack space w/ minimal repro #774

Closed
bschlenk opened this issue Feb 19, 2020 · 3 comments
Closed

ie11 Out of stack space w/ minimal repro #774

bschlenk opened this issue Feb 19, 2020 · 3 comments

Comments

@bschlenk
Copy link

Affects the latest core-js@3.6.4

Importing get-own-property-symbols before core-js web.dom-collections.iterator causes a stack overflow in ie11. get-own-property-symbols is included in webcomponentsjs polyfills, so anyone trying to use core-js with webcomponents polyfills will most likely run into this stack overflow.

I can open this issue against get-own-property-symbols too if you think the issue is on their end.

Minimal repro: https://github.com/bschlenk/ie11-corejs-stack-overflow-repro

@JakeChampion
Copy link
Contributor

it's very difficult to make a symbol polyfill/sham/shim that works with another symbol-based feature that is polyfilled, such as is the case you are describing.

I would advise to try and use the symbol polyfill provided by core-js and not the get-own-property-symbols one if at all possible.

@bschlenk
Copy link
Author

What I don't understand is, don't most polyfills first do a check to see if the polyfill needs to be added? If I already have Symbol polyfilled, then why isn't this triggering that check? I'm okay with a workaround for now, but this issue gets brought up time and time again (#735, #686, #545, #463, #387, #143) and closed without a real resolution. I figured providing a super minimal repro would be helpful.

@zloirock
Copy link
Owner

core-js should not be used together with get-own-property-symbols, core-js should not fix environment broken by other polyfills.

However, this time I'll make Symbol feature detection stricter for don't use get-own-property-symbols Symbol in core-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants