Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in v3.3.0: Node < 8 is not supported anymore by core-js-compat #669

Closed
nicolo-ribaudo opened this issue Oct 13, 2019 · 2 comments

Comments

@nicolo-ribaudo
Copy link
Contributor

Hi 馃憢

57f497d introduced the engines.node option in core-js-compat's package.json.
That package already works in node 6, since it uses only these "new" es features, which are supported in node 6

  • for...of
  • ... spread in function calls
  • Map/Set (iterator closing is not supported)

While that metadata-only change might seem innocuous, it causes yarn to fail when installing it:

error core-js-compat@3.3.1: The engine "node" is incompatible with this module. Expected version ">=8.0.0". Got "6.17.1"
error Found incompatible module.

Would it possible to revert that change and:

  1. Set in engines a node version which wasn't supported for real (e.g. >= 6.4.0, according to https://node.green/)
  2. Increase it to 8.0.0 (or higher) in core-js 4
    ?
@zloirock
Copy link
Owner

Previous versions of this package were not compatible with Node 8-, moreover, with Node 8.3-, since here was used object spread syntax. Node 6 was available to work only in some cases like loading JSON data. Ok, I'll remove this field.

@nicolo-ribaudo
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants