Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cross-compiling for Power9. #1518

Merged
merged 2 commits into from Jun 11, 2023
Merged

Add support for cross-compiling for Power9. #1518

merged 2 commits into from Jun 11, 2023

Conversation

mtl1979
Copy link
Collaborator

@mtl1979 mtl1979 commented Jun 9, 2023 •
edited by Dead2

  • Add toolchain files to use Power9 for qemu
  • Add Power9 CI runs for cmake
  • Fix build for little-endian 64-bit PowerPC

Fixes #1516

@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (f75c685) 83.80% compared to head (d167620) 83.91%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1518      +/-   ##
===========================================
+ Coverage    83.80%   83.91%   +0.11%     
===========================================
  Files          132      132              
  Lines        10847    10848       +1     
  Branches      2792     2792              
===========================================
+ Hits          9090     9103      +13     
+ Misses        1059     1046      -13     
- Partials       698      699       +1
Flag Coverage Δ
macos_clang 42.97% <ø> (ø)
macos_gcc 73.71% <ø> (ø)
ubuntu_clang 82.30% <ø> (-1.26%) ⬇️
ubuntu_clang_debug 82.17% <ø> (-0.98%) ⬇️
ubuntu_clang_inflate_allow_invalid_dist 82.19% <ø> (-1.03%) ⬇️
ubuntu_clang_inflate_strict 82.29% <ø> (-1.26%) ⬇️
ubuntu_clang_mmap 82.85% <ø> (ø)
ubuntu_clang_pigz 14.21% <ø> (ø)
ubuntu_clang_pigz_no_optim 11.61% <ø> (ø)
ubuntu_clang_pigz_no_threads 14.03% <ø> (ø)
ubuntu_clang_reduced_mem 82.93% <ø> (-1.03%) ⬇️
ubuntu_clang_toolchain_riscv ∅ <ø> (∅)
ubuntu_gcc 75.27% <ø> (-0.75%) ⬇️
ubuntu_gcc_aarch64 77.44% <ø> (ø)
ubuntu_gcc_aarch64_compat_no_opt 75.73% <ø> (ø)
ubuntu_gcc_aarch64_no_acle 76.26% <ø> (ø)
ubuntu_gcc_aarch64_no_neon 76.26% <ø> (ø)
ubuntu_gcc_armhf 77.51% <ø> (ø)
ubuntu_gcc_armhf_compat_no_opt 75.68% <ø> (-0.02%) ⬇️
ubuntu_gcc_armhf_no_acle 77.47% <ø> (ø)
ubuntu_gcc_armhf_no_neon 77.37% <ø> (ø)
ubuntu_gcc_armsf 74.83% <ø> (ø)
ubuntu_gcc_armsf_compat_no_opt 74.29% <ø> (-0.02%) ⬇️
ubuntu_gcc_benchmark 73.73% <ø> (-0.25%) ⬇️
ubuntu_gcc_compat_no_opt 76.88% <ø> (-0.02%) ⬇️
ubuntu_gcc_compat_sprefix 73.75% <ø> (ø)
ubuntu_gcc_m32 73.55% <ø> (-0.43%) ⬇️
ubuntu_gcc_mingw_i686 73.60% <ø> (ø)
ubuntu_gcc_mingw_x86_64 ?
ubuntu_gcc_mips 75.08% <ø> (ø)
ubuntu_gcc_mips64 75.09% <ø> (ø)
ubuntu_gcc_no_avx2 74.37% <ø> (ø)
ubuntu_gcc_no_ctz 74.82% <ø> (ø)
ubuntu_gcc_no_ctzll 74.81% <ø> (ø)
ubuntu_gcc_no_pclmulqdq 74.36% <ø> (-0.70%) ⬇️
ubuntu_gcc_no_sse2 74.63% <ø> (-0.68%) ⬇️
ubuntu_gcc_no_sse42 74.81% <ø> (-0.22%) ⬇️
ubuntu_gcc_o1 74.20% <ø> (-0.74%) ⬇️
ubuntu_gcc_osb ∅ <ø> (∅)
ubuntu_gcc_pigz 38.37% <ø> (ø)
ubuntu_gcc_pigz_aarch64 39.23% <ø> (-0.03%) ⬇️
ubuntu_gcc_ppc 74.09% <ø> (ø)
ubuntu_gcc_ppc64 74.52% <ø> (ø)
ubuntu_gcc_ppc64_power9 74.69% <ø> (?)
ubuntu_gcc_ppc64le 74.53% <0.00%> (ø)
ubuntu_gcc_ppc64le_novsx 74.90% <100.00%> (?)
ubuntu_gcc_ppc64le_power9 74.47% <0.00%> (?)
ubuntu_gcc_ppc_no_power8 74.78% <ø> (ø)
ubuntu_gcc_s390x 74.97% <ø> (ø)
ubuntu_gcc_s390x_dfltcc 72.04% <ø> (ø)
ubuntu_gcc_s390x_dfltcc_compat 74.06% <ø> (ø)
ubuntu_gcc_s390x_no_crc32 74.76% <ø> (ø)
ubuntu_gcc_sparc64 74.90% <ø> (ø)
ubuntu_gcc_sprefix 73.40% <ø> (-0.59%) ⬇️
win64_gcc 74.10% <ø> (-0.46%) ⬇️
win64_gcc_compat_no_opt 74.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
arch/power/compare256_power9.c 100.00% <ø> (+100.00%) ⬆️
arch/power/adler32_vmx.c 97.43% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KungFuJesus KungFuJesus mentioned this pull request Jun 9, 2023
Open
@mtl1979 mtl1979 force-pushed the ci-power9 branch 3 times, most recently from b755930 to 12a9247 Compare June 9, 2023 20:51
@mtl1979 mtl1979 marked this pull request as ready for review June 9, 2023 23:02
@Dead2 Dead2 merged commit e5ab589 into zlib-ng:develop Jun 11, 2023
133 of 134 checks passed
@Dead2 Dead2 mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmoinvaz nmoinvaz nmoinvaz approved these changes

@KungFuJesus KungFuJesus KungFuJesus approved these changes

@Dead2 Dead2 Dead2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.1.2 seems to fail tests on ppc64le with musl libc
4 participants
@mtl1979 @nmoinvaz @KungFuJesus @Dead2