Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.60.0 #78

Open
str4d opened this issue Apr 26, 2022 · 3 comments
Open

Bump MSRV to 1.60.0 #78

str4d opened this issue Apr 26, 2022 · 3 comments

Comments

@str4d
Copy link
Member

str4d commented Apr 26, 2022

Rationale:

  • Weak dependency features (so we can conditionally enable ff_derive features based on ff features without force-enabling ff_derive).

1.60.0 was released April 7, so we won't be doing this before July at the earliest. ff 0.12 will have MSRV 1.56 (#74).

@koivunej
Copy link
Contributor

Would suggest considering specifiying rust-version = "1.60" in Cargo.toml but that's a growing list of:

  • gh actions workflow
  • rust-toolchain
  • README.md

Perhaps README.md mention could be dropped off in favor of cargo metadata?

@str4d
Copy link
Member Author

str4d commented Apr 28, 2022

I will be doing that for 1.56, as that's the first release that supports it.

@str4d
Copy link
Member Author

str4d commented Oct 28, 2022

We are about to cut 0.12.1 (#92), after which we will be making breaking changes that necessitate an 0.13. I am contemplating making this MSRV bump in 0.13, but will check what the MSRVs are in downstream crates first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants