Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement From<Box<dyn Diagnostic>> for MietteDiagnostic #285

Open
ManicMarrc opened this issue Aug 20, 2023 · 2 comments
Open

Implement From<Box<dyn Diagnostic>> for MietteDiagnostic #285

ManicMarrc opened this issue Aug 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ManicMarrc
Copy link
Contributor

This could be useful for creating and modifying a dynamic diagnostic using an already existing diagnostic.
@milesj
Copy link

milesj commented Apr 22, 2024

Did you ever resolve this in anyway? I'm looking into boxing errors to reduce enum sizes, and something like this would help being built-in.

@zkat
Copy link
Owner

zkat commented Apr 22, 2024

I'll take a PR for it if any of y'all want to toss one over :)

@zkat zkat added the enhancement New feature or request label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zkat @milesj @ManicMarrc