This repository has been archived by the owner on Jun 12, 2022. It is now read-only.
Handle highWaterMark potentially false #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
appveyor failing because npm@latest doesn't support node 9, apparently Definitely seems like issues with not maintaining CI, but I'm guessing nothing else is ever getting in since no one uses this module now. Oh well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #70 (I think)
If the content-length header is empty,
sizegets set tofalse, which is sent in as thehighWaterMarkoption tothrough2, which is passed toreadable-stream, which eventually raises an error saying "false is not a valid value" or something similar, but only on version 3.x, which is whatnpmuses (even though this project doesn't).I did write a test for this, but could never get it to trigger because it's caused by some sort of dependency mismatch that happens in npm but not in this repo, so I removed the test. Even when I installed readable-stream@3.x, it didn't trigger, because
through2is the only dependency that requiresreadable-stream, which is not the case innpm. When I updated justthrough2'sreadable-streamversion, I got a different error entirely, so I'm not sure if this weird dependency thing is the only issue, but I do know we're not supposed to passhighWaterMark: false, so this should still be a valid fix.