Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HS256 support #412

Open
abogdanov37 opened this issue Jun 19, 2023 · 1 comment
Open

Add HS256 support #412

abogdanov37 opened this issue Jun 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@abogdanov37
Copy link

Is your feature request related to a problem? Please describe.
As a legasy service I can use onli tokens which signature based on H256
But now when I try to emit token I get an error
From code

oidc/pkg/crypto/hash.go

Lines 16 to 27 in 9e62498

func GetHashAlgorithm(sigAlgorithm jose.SignatureAlgorithm) (hash.Hash, error) {
switch sigAlgorithm {
case jose.RS256, jose.ES256, jose.PS256:
return sha256.New(), nil
case jose.RS384, jose.ES384, jose.PS384:
return sha512.New384(), nil
case jose.RS512, jose.ES512, jose.PS512:
return sha512.New(), nil
default:
return nil, fmt.Errorf("%w: %q", ErrUnsupportedAlgorithm, sigAlgorithm)
}
}

Describe the solution you'd like
I want that library support this algorithm

Describe alternatives you've considered
Does not see alternatives

Additional context
I try to create my own OP

@abogdanov37 abogdanov37 added the enhancement New feature or request label Jun 19, 2023
@hifabienne
Copy link
Member

Thank you for sharing your idea.
If there is a significant demand from customers, we will carefully consider implementing the feature.
Currently, the issue will be added to our product backlog.
Meanwhile, if you're interested in implementing it yourself, we also welcome pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📨 Product Backlog
Development

No branches or pull requests

2 participants