Refactoring and next version of OIDC

[muhlemmer]

Dear community. I've recently started at zitadel. Firstly I'm tasked to help evolve this OIDC library. I will look in things like #116, merging of #173 and refactoring the library to use more concrete typing instead of interfaces for return types. Where possible or needed, we are also thinking about using generics to allow consumers to replace certain types for customization.

All of the above ideas will imply breaking changes, so we are planning a new major release once all of that is done. In order to facilitate this and keep main stable, we have created the next branch where breaking change pull-requests will be targeted. Also, issues and pull-request targeting the next version will be added to the v2 milestone, so we can keep track of them.

@muir, I've noticed the NEXT_RELEASE.md file. If you have some time to spare, may I ask you to convert these lines into issues, so that we can pick them up? Or pull requests are also welcome, of course :)

oidc/NEXT_RELEASE.md

Lines 4 to 6 in 3a6c354

	- Add `rp/RelyingParty.GetRevokeEndpoint`
	- Rename `op/OpStorage.GetKeyByIDAndUserID` to `op/OpStorage.GetKeyByIDAndClientID`
	- Add `CanRefreshTokenInfo` (`GetRefreshTokenInfo()`) to `op.Storage`

[muhlemmer]

WIP: #283

[muhlemmer]

@zitadel/engineers should we also get rid of the op.Configuration interface? It is currently implemented only by op.Provider. op.Provider is configured by the exported op.Config , which is a subset of the options in op.Configuration .

oidc/pkg/op/config.go

Lines 17 to 43 in c8d61c0

	type Configuration interface {
	Issuer() string
	AuthorizationEndpoint() Endpoint
	TokenEndpoint() Endpoint
	IntrospectionEndpoint() Endpoint
	UserinfoEndpoint() Endpoint
	RevocationEndpoint() Endpoint
	EndSessionEndpoint() Endpoint
	KeysEndpoint() Endpoint
	AuthMethodPostSupported() bool
	CodeMethodS256Supported() bool
	AuthMethodPrivateKeyJWTSupported() bool
	TokenEndpointSigningAlgorithmsSupported() []string
	GrantTypeRefreshTokenSupported() bool
	GrantTypeTokenExchangeSupported() bool
	GrantTypeJWTAuthorizationSupported() bool
	GrantTypeClientCredentialsSupported() bool
	IntrospectionAuthMethodPrivateKeyJWTSupported() bool
	IntrospectionEndpointSigningAlgorithmsSupported() []string
	RevocationAuthMethodPrivateKeyJWTSupported() bool
	RevocationEndpointSigningAlgorithmsSupported() []string
	RequestObjectSupported() bool
	RequestObjectSigningAlgorithmsSupported() []string
	SupportedUILocales() []language.Tag
	}

[adlerhurst]

Sounds good to me. I think i haven't used any other lib where config is an interface

[muir]

@muhlemmer
The things I put in NEXT-RELEASE.md are all trivial changes. The reason I didn't already do them is that they break backwards compatibility. I can send a PR if you want.

[muhlemmer]

That would be great. Please target the next branch for this.

[muir]

I also want to draw your attention to a particular discord thread. It's not active right now, but it's an appropriate place for discussions like these: https://discord.com/channels/927474939156643850/1019895518383583323/threads/1024593088016031744

[muhlemmer]

The link doesn't drop me in any thread somehow. Just the server. That might be lack of integration between my browser and the discord app on gentoo :P. Would you mind making a mention in the thread? My nick is @tim on discord.