Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #90

Merged
merged 6 commits into from Mar 25, 2020
Merged

Update .travis.yml #90

merged 6 commits into from Mar 25, 2020

Conversation

sobolevn
Copy link
Contributor

@sobolevn sobolevn commented Mar 9, 2020

Closes #89

@sobolevn
Copy link
Contributor Author

sobolevn commented Mar 9, 2020

@zheller any ideas why the tests are failing?

@twolfson
Copy link
Collaborator

twolfson commented Mar 9, 2020

Neither of us have maintained this project in a while so @sobolevn, your guess is as good as ours -- especially since you seem to know more about what's changed in Python 3.7. Do you mind taking a look?

Travis CI failures can be seen by clicking on the link provided by GitHub. Here's the 3.7 failure:

https://travis-ci.org/zheller/flake8-quotes/jobs/660032029

Traceback (most recent call last):

  File "/home/travis/build/zheller/flake8-quotes/test/test_checks.py", line 23, in test_stdin

    self.assertEqual(stderr, b'')

AssertionError: b"/home/travis/virtualenv/python3.7.1/lib/[155 chars]')\n" != b''

@sobolevn
Copy link
Contributor Author

sobolevn commented Mar 9, 2020

Sure, I will refactor the tests today 👍

@twolfson
Copy link
Collaborator

twolfson commented Mar 9, 2020

Unsure that refactoring is necessary ._. Maybe triage first and report back so you don't waste time with a refactor?

@skirpichev
Copy link
Contributor

@twolfson, are you ok with the flake8 requirement change?

@twolfson
Copy link
Collaborator

Ah, didn't realize this PR was ready for review. Looking over now

requirements-dev.txt Outdated Show resolved Hide resolved
setup.py Outdated
@@ -28,7 +28,7 @@ def read(*filenames, **kwargs):
author_email='zheller@gmail.com',
version=about['__version__'],
install_requires=[
'flake8',
'flake8>=3.5',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this change a little more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason resolved flake8 version was 3.2
It didn't work with 3.8

The first version of flake8 which worked is 3.5

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I'd expect the requirements-dev.txt to supercede this. It looks like in fact, that is what was happening and this change wasn't respected in Travis CI:

(I think you mean flake8@3.3, not 3.2 for Python 3.8)

750f4a0

https://travis-ci.org/github/zheller/flake8-quotes/jobs/660092929#L191

The following change where you updated requirements-dev.txt installs appropriately

https://travis-ci.org/github/zheller/flake8-quotes/jobs/660095678#L191

795cbac

Can you rollback this line change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I can edit the file in the PR directly so going to do that for speedier turnaround

@twolfson
Copy link
Collaborator

Looks like proper version from requirements-dev.txt installed correctly even after rollback 👍

https://travis-ci.org/github/zheller/flake8-quotes/jobs/666956750#L190

Landing now

@twolfson
Copy link
Collaborator

Fwiw, nothing public facing changed so only landing this as a patch revision)

@twolfson twolfson merged commit 63b6bd3 into zheller:master Mar 25, 2020
@twolfson
Copy link
Collaborator

Released in 2.1.2. Thanks for the PR =)

@sobolevn
Copy link
Contributor Author

Thanks a lot! 👍

@sobolevn sobolevn deleted the patch-1 branch March 25, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test cases for python3.7 and python3.8
3 participants