Make the error message show what kind of string is bad. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twolfson
reviewed
Aug 20, 2021
There was a problem hiding this comment.
Ehh, I have a lot of nitpicks around this implementation =/ Will just commandeer rather than try to force mindreading =/ Will update + land by Fri Aug 27
- Would prefer messages be written out as-is inside the
INLINEandMULTILINEconfigs (good for i18n flexibility) - New messages are very verbose, worry about being too noisy for console feedback
- Disliking how tests are using variables in assertion expectationss (should almost always be avoided as it can lead to more levels of indirection which makes testing unclear)
|
Sure, go for it, thanks. |
|
Looking into this now. As a heads up, this branch is currently failing |
|
That was kind of tedious but it's all back to functional now. Landing PR |
|
This has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #102