diff --git a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceClassPostProcessor.java b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceClassPostProcessor.java index f07b4cec430..3181ca1ad70 100644 --- a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceClassPostProcessor.java +++ b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ServiceClassPostProcessor.java @@ -162,9 +162,13 @@ private void registerServiceBeans(Set packagesToScan, BeanDefinitionRegi }); for (String packageToScan : packagesToScan) { - + + // Registers @Service Bean first + scanner.scan(packageToScan); + // Finds all BeanDefinitionHolders of @Service whether @ComponentScan scans or not. - Set beanDefinitionHolders = scanner.doScan(registry, beanNameGenerator, packageToScan); + Set beanDefinitionHolders = + findServiceBeanDefinitionHolders(scanner, packageToScan, registry, beanNameGenerator); if (!CollectionUtils.isEmpty(beanDefinitionHolders)) { diff --git a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java index 384be40af99..45e10e4d365 100644 --- a/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java +++ b/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java @@ -16,17 +16,13 @@ */ package org.apache.dubbo.config.spring.context.annotation; -import org.apache.dubbo.common.utils.CollectionUtils; import org.springframework.beans.factory.config.BeanDefinition; -import org.springframework.beans.factory.config.BeanDefinitionHolder; import org.springframework.beans.factory.support.BeanDefinitionRegistry; -import org.springframework.beans.factory.support.BeanNameGenerator; import org.springframework.context.annotation.ClassPathBeanDefinitionScanner; -import org.springframework.context.annotation.ComponentScan; import org.springframework.core.env.Environment; import org.springframework.core.io.ResourceLoader; -import java.util.LinkedHashSet; +import java.util.Objects; import java.util.Set; import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentMap; @@ -42,6 +38,9 @@ */ public class DubboClassPathBeanDefinitionScanner extends ClassPathBeanDefinitionScanner { + /** + * key is package, value is BeanDefinition + */ private final ConcurrentMap> beanDefinitionMap = new ConcurrentHashMap<>(); public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, boolean useDefaultFilters, Environment environment, @@ -64,11 +63,6 @@ public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, Envi } - @Override - public Set doScan(String... basePackages) { - return super.doScan(basePackages); - } - @Override public boolean checkCandidate(String beanName, BeanDefinition beanDefinition) throws IllegalStateException { return super.checkCandidate(beanName, beanDefinition); @@ -77,32 +71,12 @@ public boolean checkCandidate(String beanName, BeanDefinition beanDefinition) th @Override public Set findCandidateComponents(String basePackage) { Set beanDefinitions = beanDefinitionMap.get(basePackage); - if (CollectionUtils.isEmpty(beanDefinitions)) { + // if beanDefinitions size ge 0 => don't scan + // if beanDefinitions size is null => scan + if (Objects.isNull(beanDefinitions)) { beanDefinitions = super.findCandidateComponents(basePackage); beanDefinitionMap.put(basePackage, beanDefinitions); } return beanDefinitions; } - - /** - * Registers @Service Bean and Finds all BeanDefinitionHolders of @Service - * - * @param registry BeanDefinitionRegistry - * @param beanNameGenerator BeanNameGenerator - * @param basePackage basePackage - * @return all BeanDefinitionHolders of @Service - */ - public Set doScan(BeanDefinitionRegistry registry, BeanNameGenerator beanNameGenerator, String basePackage) { - // Registers @Service Bean first - super.doScan(basePackage); - Set beanDefinitions = findCandidateComponents(basePackage); - Set beanDefinitionHolders = new LinkedHashSet(beanDefinitions.size()); - for (BeanDefinition beanDefinition : beanDefinitions) { - String beanName = beanNameGenerator.generateBeanName(beanDefinition, registry); - BeanDefinitionHolder beanDefinitionHolder = new BeanDefinitionHolder(beanDefinition, beanName); - beanDefinitionHolders.add(beanDefinitionHolder); - } - return beanDefinitionHolders; - } - }