You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can't seem to select a number in the number selector in the tags filter, when selecting "at least" version of the filter.
Steps to reproduce
Go to somewhere with a smart search dialog
Select to add/remove people, and select "Based on tags"
Select "at least" from the dropdown
Attempt to edit the number
Expected Behaviour
I can edit the number either from clicking the field and then using the keyboard for deleting the existing number and typing in a new one, or by using the little up/down arrow buttons to increase or decrease the number
Actual Behaviour
I cannot use the up/down arrow buttons, and when I attempt to delete the existing number to type in a new one, the filter changes and I cannot change back to the "at least" version.
Screenshots (if you have any)
tags.bug.mp4
The text was updated successfully, but these errors were encountered:
Two different problems, with a third bigger one underneath:
Not being able to increase the number is just because there have been no tags selected yet, and the number field has a maximum attribute bounded by that. So mostly a UX issue. Simple solution is to just allow any number to be entered here, not sure we need the upper bound. Or you can max out at the maximum selectable amount of tags, maybe.
Deleting the number causing a reset to any is caused by a definition loop where having a value in the number field is seen as the setting keeping the form in the min_matching state. Looks like we're trying to not mess with the CONDITION_OPERATOR enum, because that touches on a handful of unrelated uses. But, of course, when you then delete the min_matching number value, the form reverts to the default any state. I'll do a fix this in the current mold, but there should maybe be an expansion of the CONDITION_OPERATOR enum considered.
The promised third, bigger, problem is that I am not sure this filter even works correctly. Regardless of the min_matching value, the filter still seems to just work like the any condition.
Description
I can't seem to select a number in the number selector in the tags filter, when selecting "at least" version of the filter.
Steps to reproduce
Expected Behaviour
I can edit the number either from clicking the field and then using the keyboard for deleting the existing number and typing in a new one, or by using the little up/down arrow buttons to increase or decrease the number
Actual Behaviour
I cannot use the up/down arrow buttons, and when I attempt to delete the existing number to type in a new one, the filter changes and I cannot change back to the "at least" version.
Screenshots (if you have any)
tags.bug.mp4
The text was updated successfully, but these errors were encountered: