From ca10bbbaefaf5bc8cbcb64f9139fe93356f92967 Mon Sep 17 00:00:00 2001 From: "dawn.zhou" Date: Mon, 19 Sep 2022 11:39:52 +0800 Subject: [PATCH] refactor: redis error for prometheus metric label --- core/stores/redis/hook.go | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/core/stores/redis/hook.go b/core/stores/redis/hook.go index 5229bd274425..7994fdd75654 100644 --- a/core/stores/redis/hook.go +++ b/core/stores/redis/hook.go @@ -2,10 +2,13 @@ package redis import ( "context" + "io" + "net" "strings" "time" red "github.com/go-redis/redis/v8" + "github.com/zeromicro/go-zero/core/breaker" "github.com/zeromicro/go-zero/core/errorx" "github.com/zeromicro/go-zero/core/logx" "github.com/zeromicro/go-zero/core/mapping" @@ -116,24 +119,17 @@ func formatError(err error) string { return "" } - es := err.Error() - switch { - case strings.HasPrefix(es, "read"): - return "read timeout" - case strings.HasPrefix(es, "dial"): - if strings.Contains(es, "connection refused") { - return "connection refused" - } - return "dial timeout" - case strings.HasPrefix(es, "write"): - return "write timeout" - case strings.Contains(es, "EOF"): + opErr, ok := err.(*net.OpError) + if ok && opErr.Timeout() { + return "timeout" + } + + switch err { + case io.EOF: return "eof" - case strings.Contains(es, "reset"): - return "reset" - case strings.Contains(es, "broken"): - return "broken pipe" - case strings.Contains(es, "breaker"): + case context.DeadlineExceeded: + return "context deadline" + case breaker.ErrServiceUnavailable: return "breaker" default: return "unexpected error"