Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:duplicate route check #2154

Merged
merged 1 commit into from Jul 24, 2022
Merged

Conversation

fisnone
Copy link
Contributor

@fisnone fisnone commented Jul 15, 2022

fix: goctl genroute check duplicate route

在a有prefix,b无prefix下会出现异常报错,实际上加上prefix并无重复
Reason:
a.api
@server (
group: foo
prefix: foo
)
service api {

@handler templatesget
get /templates (req)  returns (res)

}

b.api
@server (
group: bar
)
service api {

@handler templatesget
get /templates (req)  returns (res)

}

@kevwan kevwan requested a review from kesonan July 23, 2022 04:49
Copy link
Collaborator

@kesonan kesonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevwan kevwan merged commit 685d14e into zeromicro:master Jul 24, 2022
kevwan pushed a commit to kevwan/go-zero that referenced this pull request Jul 24, 2022
Co-authored-by: 黄志荣 <huangzhirong@shuinfo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants