Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add go-grpc_opt and go_opt for grpc new command #1769

Merged
merged 2 commits into from Apr 21, 2022

Conversation

chowyu12
Copy link
Contributor

@chowyu12 chowyu12 commented Apr 7, 2022

add go-grpc_opt and go_opt for grpc new command

@chowyu12 chowyu12 changed the title add go-grpc_opt and go_opt for grpc new command feat: add go-grpc_opt and go_opt for grpc new command Apr 7, 2022
@kesonan
Copy link
Collaborator

kesonan commented Apr 8, 2022

@chowyu12 rpc new 为什么需要这两个参数,由于 goctl rpc new 的proto内容都是内置生成的,所以不存在proto不规范问题,一般*_opt主要用于控制 go_package ,所以这里我认为没有必要。

Why does rpc new need these two parameters? Since the proto content of goctl rpc new is built-in, there is no proto irregularity problem. Generally, *_opt is mainly used to control go_package, so I don't think it is necessary here.

@chowyu12
Copy link
Contributor Author

chowyu12 commented Apr 9, 2022

@anqiansong 我这边项目使用了自定义模板,基于https://github.com/zeromicro/go-zero-template, 更新的goctl后生成的代码反馈错误
image

goctl更新前后区别是:
image

使用--go-grpc_opt=require_unimplemented_servers=false 可以解决

@kevwan kevwan merged commit 14bf2f3 into zeromicro:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants