Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support component variants #40

Merged
merged 2 commits into from Jan 12, 2021
Merged

Support component variants #40

merged 2 commits into from Jan 12, 2021

Conversation

dirtybit
Copy link
Member

@dirtybit dirtybit commented Jan 8, 2021

This PR adds sample data and fixture data for component variants. Also, component and screen functions are added to the exec command.

Copy link
Contributor

@skarahoda skarahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, Change of template test file is missing

@dirtybit
Copy link
Member Author

Looks good. However, Change of template test file is missing

What "change" are you referring to? 😅

@skarahoda
Copy link
Contributor

skarahoda commented Jan 12, 2021

Looks good. However, Change of template test file is missing

What "change" are you referring to? 😅

I was referring to adding test case for component variants. Oooh we don't need a test case for them. They are added in fixtures and we generate test cases in a loop. Ignore my previous comment.

@dirtybit dirtybit merged commit 0aa06c6 into master Jan 12, 2021
@dirtybit dirtybit deleted the feature/component-variants branch January 12, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants