Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Zend controller test contains #30

Open
GeeH opened this issue Jun 28, 2016 · 1 comment
Open

Zend controller test contains #30

GeeH opened this issue Jun 28, 2016 · 1 comment

Comments

@GeeH
Copy link
Contributor

GeeH commented Jun 28, 2016

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/6729
User: @nbochenko
Created On: 2014-10-03T08:22:02Z
Updated At: 2015-05-31T10:16:20Z
Body
This allow to match a partial query node value content in AbstractHttpControllerTestCase:: assertQueryContentContains, and not only an exact match.
A node with the value "foo, bar, lol" would match "foo", "foo,", "bar, lol", etc...

@blanchonvincent


Comment

User: @blanchonvincent
Created On: 2014-10-03T12:33:43Z
Updated At: 2014-10-03T12:33:43Z
Body
@nbochenko you should do the same work with assertResponseHeaderContains to keep consistency


Comment

User: @nbochenko
Created On: 2014-10-04T15:06:09Z
Updated At: 2014-10-04T15:06:09Z
Body
@blanchonvincent
🍸


Comment

User: @blanchonvincent
Created On: 2014-10-04T15:33:56Z
Updated At: 2014-10-04T15:33:56Z
Body
@nbochenko 🎉
That's ok for me, thanks


Comment

User: @nbochenko
Created On: 2014-12-03T06:08:34Z
Updated At: 2014-12-03T06:08:34Z
Body
@blanchonvincent


Comment

User: @Ocramius
Created On: 2014-12-24T00:46:01Z
Updated At: 2014-12-24T00:46:01Z
Body
I'd actually like to have separate methods for this new logic, as it increases readability and makes it simpler to use them.


Comment

User: @weierophinney
Created On: 2015-02-19T19:54:36Z
Updated At: 2015-02-19T19:54:36Z
Body
I tend to agree with @Ocramius ; new method names would make it easier to understand intent of the test (looking at the method name is simpler than looking at the arguments to the assertion method).

If you're willing to make that change, I'm happy to schedule this for 2.4; timeframe is ~ 9 March 2015.


Comment

User: @nbochenko
Created On: 2015-05-23T07:40:10Z
Updated At: 2015-05-23T07:41:20Z
Body
@weierophinney @Ocramius
Sorry for the delay.
The "***Contains" methods are actually asserting an exact match.
What method names would you like to add, something like :
"assertResponseHeaderPartiallyContains"
"assertXpathQueryContentPartiallyContains"
and so on?

Thanks.


Comment

User: @nbochenko
Created On: 2015-05-31T04:57:17Z
Updated At: 2015-05-31T04:57:17Z
Body
@blanchonvincent @waltertamboer @Ocramius


Comment

User: @waltertamboer
Created On: 2015-05-31T10:16:20Z
Updated At: 2015-05-31T10:16:20Z
Body
I guess you meant to ping @weierophinney instead of me :)


@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-test; a new issue has been opened at laminas/laminas-test#5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants