Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Added Reader/Writer methods and tests for <itunes:title> on entry level #96

Closed
wants to merge 1 commit into from

Conversation

podcasthosting
Copy link

There is a (new) field in the Itunes podcast spec for the episode title.
See https://help.apple.com/itc/podcasts_connect/#/itcb54353390 > Episode descriptions > itunes:title

The pull requests adds the missing methods for reading and writing a feed and the tests.

@froschdesign
Copy link
Member

@podcasthosting
Do you know if there is finally a file for the DTD?

@froschdesign froschdesign added this to the 2.12.0 milestone Mar 1, 2019
*
* @return string
*/
public function getTitle()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmmh, a test class for the entire Zend\Feed\Reader\Extension\Podcast\Entry is missing.
I will create a separate issue report for this problem.

@froschdesign
Copy link
Member

@podcasthosting
Thanks for your contribution, I will check later in the day.

@froschdesign
Copy link
Member

@OpenHaus
Can you answer my previous question?

Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

(The coding standard is a separate topic and is related to the whole component.)

Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@podcasthosting @OpenHaus
Please use the develop branch for new features. Thanks!

Compare with: https://github.com/zendframework/zend-feed/blob/master/docs/PULL_REQUEST_TEMPLATE.md

@podcasthosting
Copy link
Author

@podcasthosting
Do you know if there is finally a file for the DTD?

It does not seem so. The uri referencing the DTD in the specs is not reachable:

<rss xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd" version="2.0">

I have no further information.

@froschdesign
Copy link
Member

@podcasthosting

I have no further information.

Okay, thanks for the feedback anyway. 👍
(I was hoping we could simplify the unit tests.)

weierophinney added a commit that referenced this pull request Mar 5, 2019
@weierophinney
Copy link
Member

Thanks, @podcasthosting! I rebased your branch against develop, and merged against develop for the upcoming 2.12.0 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants