This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Allow usage of Reader without GooglePlayPodcast extension #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
force-pushed
the
hotfix/google-play-podcast-extension-entry
branch
from
e8aaf8b
to
2c09572
Compare
|
Test failures are all due to network timeouts when testing remote feed parsing. |
Custom implementations of `ExtensionManagerInterface` may not have _new core_ extensions present. As a result, when upgrading, an exception is thrown due to inability to load the new extension. This was discovered with the 2.10 release, when we added a new core extension, GooglePlayPodcast; see zendframework#80 and https://www.drupal.org/project/drupal/issues/2976335 for more details. As such, we now check for _new_ core extensions before registering them. When we discover they are not in the extension manager, we emit an `E_USER_NOTICE` indicating the user should update their `ExtensionManagerInterface` implementation to add entries for the new extension, but then continue on without registering the extension. This ensures no exception is thrown.
weierophinney
force-pushed
the
hotfix/google-play-podcast-extension-entry
branch
from
2c09572
to
dfbb10f
Compare
…t extension This patch adapts the same pattern used in the `Reader` subcomponent with regards to conditionally loading newly introduced extensions to the `Writer` subcomponent: if the extension manager does not know of the extension, it is not registered, and an `E_USER_NOTICE` is emitted prompting the developer to add entries to their extension manager implementation.
weierophinney
added a commit
that referenced
this pull request
Jun 18, 2018
weierophinney
added a commit
that referenced
this pull request
Jun 18, 2018
Forward port #81 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom implementations of
ExtensionManagerInterfacemay not have new core extensions present. As a result, when upgrading, an exception is thrown due to inability to load the new extension.This was discovered with the 2.10 release, when we added a new core extension, GooglePlayPodcast; see #80 and https://www.drupal.org/project/drupal/issues/2976335 for more details.
As such, we now check for new core extensions before registering them. When we discover they are not in the extension manager, we emit an
E_USER_NOTICEindicating the user should update theirExtensionManagerInterfaceimplementation to add entries for the new extension, but then continue on without registering the extension. This ensures no exception is thrown.