Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Probably an incorrect test case testAuthorityIsPrefixedByDoubleSlashIfPresent in UriTest.php #381

Open
Keksov opened this issue Dec 3, 2019 · 1 comment

Comments

@Keksov
Copy link

Keksov commented Dec 3, 2019

Two tests are looking identical despite description. Probably withHost in second case should be replaced by something else.

    public function testUriDoesNotAppendColonToHostIfPortIsEmpty()
    {
        $uri = (new Uri())->withHost('google.com');
        $this->assertSame('//google.com', (string) $uri);
    }
    public function testAuthorityIsPrefixedByDoubleSlashIfPresent()
    {
        $uri = (new Uri())->withHost('example.com');
        $this->assertSame('//example.com', (string) $uri);
    }
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-diactoros; a new issue has been opened at laminas/laminas-diactoros#1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants