Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Hack Typechecker definitions needed #180

Open
barbu110 opened this issue Jun 4, 2016 · 5 comments
Open

Hack Typechecker definitions needed #180

barbu110 opened this issue Jun 4, 2016 · 5 comments

Comments

@barbu110
Copy link

barbu110 commented Jun 4, 2016

Hi!

This module is excellent, but in a strict Hack project, is has no use, unfortunately, because of the lack of typechecker definitions.

Me and, for sure, many others, would appreciate if you wrote typechecker definitions!

@weierophinney
Copy link
Member

Would you be willing to provide a patch with them, please?

@barbu110
Copy link
Author

barbu110 commented Jun 4, 2016

I am working on something, but I do not have time to finish them very soon.

@sandrokeil
Copy link

@barbu110 What's the problem in a strict typed PHP 7 project?

@barbu110
Copy link
Author

barbu110 commented Jun 4, 2016

@sandrokeil, not PHP 7, Hack. The HHVM typechecker won't recognize the code of the module because it written in <?php, not <?hh, so .hhi definitions must be provided.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-diactoros; a new issue has been opened at laminas/laminas-diactoros#21.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants