Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATH in builds #3262

Open
patrobinson opened this issue Mar 21, 2019 · 1 comment
Open

PATH in builds #3262

patrobinson opened this issue Mar 21, 2019 · 1 comment

Comments

@patrobinson
Copy link
Contributor

As per #2744 the PATH variable leaks into our jobs and this can impact using rbenv.
When samson is launched with bundle exec puma, it prepends the directory /var/www/samson/releases/1/vendor/bundle/ruby/2.5.0/bin to the PATH.

It appears this issue was introduced in 2bf25bd
Previously we were calling:

Bundler.with_clean_env do
  PTY.spawn(...)
end

This strips the path prepended by bundle exec and hence avoids conflicts with rbenv.

Should we re-introduce Bundler.with_clean_env to strip the PATH?

cc @grosser

@grosser
Copy link
Contributor

grosser commented Mar 21, 2019

kk, fix coming in a week or so ... PR welcome if you know how to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants