-
Notifications
You must be signed in to change notification settings - Fork 233
/
environment_variable_groups_controller_test.rb
327 lines (285 loc) · 9.85 KB
/
environment_variable_groups_controller_test.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
# frozen_string_literal: true
require_relative "../test_helper"
SingleCov.covered!
describe EnvironmentVariableGroupsController do
def self.it_updates
it "updates" do
variable = env_group.environment_variables.first
refute_difference "EnvironmentVariable.count" do
put :update, params: {
id: env_group.id,
environment_variable_group: {
environment_variables_attributes: {
"0" => {name: "N1", value: "V2", scope_type_and_id: "DeployGroup-#{deploy_group.id}", id: variable.id}
}
}
}
end
assert_redirected_to "/environment_variable_groups"
variable.reload.value.must_equal "V2"
variable.reload.scope.must_equal deploy_group
end
end
def self.it_destroys
it "destroy" do
env_group
assert_difference "EnvironmentVariableGroup.count", -1 do
delete :destroy, params: {id: env_group.id}
end
assert_redirected_to "/environment_variable_groups"
end
end
let(:stage) { stages(:test_staging) }
let(:project) { stage.project }
let(:deploy_group) { stage.deploy_groups.first }
let!(:env_group) do
EnvironmentVariableGroup.create!(
name: "G1",
environment_variables_attributes: {
0 => {name: "X", value: "Y"},
1 => {name: "Y", value: "Z"}
}
)
end
let!(:other_env_group) do
EnvironmentVariableGroup.create!(
name: "OtherG1",
environment_variables_attributes: {
0 => {name: "X", value: "Y"},
1 => {name: "Y", value: "Z", scope_type_and_id: "DeployGroup-#{deploy_group.id}"}
}
)
end
let(:other_project) do
p = project.dup
p.name = 'xxxxx'
p.permalink = 'xxxxx'
p.save!(validate: false)
p
end
as_a :viewer do
unauthorized :get, :new
unauthorized :post, :create
describe "#update" do
it "is unauthorized" do
patch :update, params: {id: env_group.id}
assert_response :unauthorized
end
end
describe "#destroy" do
it "is unauthorized" do
delete :destroy, params: {id: env_group.id}
assert_response :unauthorized
end
end
describe "#index" do
it "renders" do
get :index
assert_response :success
end
it "renders json" do
get :index, format: :json
assert_response :success
json_response = JSON.parse response.body
first_group = json_response['environment_variable_groups'].first
first_group.keys.must_include "name"
first_group.keys.must_include "variable_names"
first_group['name'].must_equal "G1"
first_group['variable_names'].must_equal ["X", "Y"]
end
it "renders with envionment_variables if present" do
get :index, params: {includes: "environment_variables", format: :json}
assert_response :success
project = JSON.parse(response.body)
project.keys.must_include "environment_variables"
end
end
describe "#show" do
def unauthorized_env_group
ProjectEnvironmentVariableGroup.create!(environment_variable_group: env_group, project: other_project)
end
it "renders" do
get :show, params: {id: env_group.id}
assert_response :success
end
it 'disables fields if user cannot edit env group' do
unauthorized_env_group
get :show, params: {id: env_group.id}
assert_response :success
assert_select 'fieldset[disabled]', count: 2
end
end
describe "#preview" do
it "renders for groups" do
get :preview, params: {group_id: env_group.id}
assert_response :success
end
it "renders for projects" do
get :preview, params: {project_id: project.id}
assert_response :success
end
it "calls env with preview" do
EnvironmentVariable.expects(:env).
with(anything, anything, project_specific: nil, resolve_secrets: false).times(3)
get :preview, params: {group_id: env_group.id}
assert_response :success
end
end
describe "a json GET to #preview" do
it "succeeds" do
get :preview, params: {group_id: env_group.id, project_id: project.id, preview: true}, format: :json
assert_response :success
json_response = JSON.parse response.body
json_response['groups'].sort.must_equal [
[".pod-100", {"X" => "Y", "Y" => "Z"}],
[".pod1", {"X" => "Y", "Y" => "Z"}],
[".pod2", {"X" => "Y", "Y" => "Z"}]
]
end
it "only shows single deploy_group with filtering on" do
get :preview, params: {group_id: env_group.id, project_id: project.id, deploy_group: "pod2"}, format: :json
assert_response :success
json_response = JSON.parse response.body
json_response['groups'].sort.must_equal [
[".pod2", {"X" => "Y", "Y" => "Z"}]
]
end
it "fails when deploy group is unknown" do
assert_raises ActiveRecord::RecordNotFound do
get :preview, params: {group_id: env_group.id, project_id: project.id, deploy_group: "pod23"}, format: :json
end
end
describe "project_specific" do
before do
EnvironmentVariable.create!(parent: project, name: 'B', value: 'b')
ProjectEnvironmentVariableGroup.create!(environment_variable_group: other_env_group, project: project)
end
it "renders only project env" do
get :preview, params: {project_id: project.id, project_specific: true}, format: :json
assert_response :success
json_response = JSON.parse response.body
json_response['groups'].sort.must_equal [
[".pod-100", {"B" => "b"}],
[".pod1", {"B" => "b"}],
[".pod2", {"B" => "b"}]
]
end
it "renders only groups env" do
get :preview, params: {project_id: project.id, project_specific: false}, format: :json
assert_response :success
json_response = JSON.parse response.body
json_response['groups'].sort.must_equal [
[".pod-100", {"Y" => "Z", "X" => "Y"}],
[".pod1", {"X" => "Y"}],
[".pod2", {"X" => "Y"}]
]
end
it "renders without project_specific" do
get :preview, params: {project_id: project.id, project_specific: nil}, format: :json
assert_response :success
json_response = JSON.parse response.body
json_response['groups'].sort.must_equal [
[".pod-100", {"B" => "b", "Y" => "Z", "X" => "Y"}],
[".pod1", {"B" => "b", "X" => "Y"}],
[".pod2", {"B" => "b", "X" => "Y"}]
]
end
end
end
end
as_a :project_admin do
describe "#new" do
it "renders" do
get :new
assert_response :success
end
end
describe "#create" do
it "creates" do
assert_difference "EnvironmentVariable.count", +1 do
assert_difference "EnvironmentVariableGroup.count", +1 do
post :create, params: {
environment_variable_group: {
environment_variables_attributes: {"0" => {name: "N1", value: "V1"}},
name: "G2"
}
}
end
end
assert_redirected_to "/environment_variable_groups"
end
end
describe "#update" do
let(:params) do
{
id: env_group.id,
environment_variable_group: {
name: "G2",
comment: "COOMMMENT",
environment_variables_attributes: {
"0" => {name: "N1", value: "V1"}
}
}
}
end
before { env_group }
it "adds" do
assert_difference "EnvironmentVariable.count", +1 do
put :update, params: params
end
assert_redirected_to "/environment_variable_groups"
env_group.reload
env_group.name.must_equal "G2"
env_group.comment.must_equal "COOMMMENT"
end
it_updates
it "destroys variables" do
variable = env_group.environment_variables.first
assert_difference "EnvironmentVariable.count", -1 do
put :update, params: {
id: env_group.id, environment_variable_group: {
environment_variables_attributes: {
"0" => {name: "N1", value: "V2", id: variable.id, _destroy: true}
}
}
}
end
assert_redirected_to "/environment_variable_groups"
end
it 'updates when the group is used by a project where the user is an admin' do
ProjectEnvironmentVariableGroup.create!(environment_variable_group: env_group, project: project)
assert_difference "EnvironmentVariable.count", +1 do
put :update, params: params
end
end
it "cannot update when not an admin for any used projects" do
ProjectEnvironmentVariableGroup.create!(environment_variable_group: env_group, project: other_project)
put :update, params: params
assert_response :unauthorized
end
it "cannot update when not an admin for some used projects" do
ProjectEnvironmentVariableGroup.create!(environment_variable_group: env_group, project: project)
ProjectEnvironmentVariableGroup.create!(environment_variable_group: env_group, project: other_project)
put :update, params: params
assert_response :unauthorized
end
end
describe "#destroy" do
it_destroys
it "cannot destroy when not an admin for all used projects" do
ProjectEnvironmentVariableGroup.create!(environment_variable_group: env_group, project: other_project)
delete :destroy, params: {id: env_group.id}
assert_response :unauthorized
end
end
end
as_a :admin do
describe "#update" do
before { env_group }
it_updates
end
describe "#destroy" do
it_destroys
end
end
end