Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't mutate original object in unset #499

Merged
merged 1 commit into from
Nov 12, 2020
Merged

fix: don't mutate original object in unset #499

merged 1 commit into from
Nov 12, 2020

Conversation

juanjoDiaz
Copy link
Collaborator

Fix small issue introduced in #496 which might modify the original data

@martinfrancois
Copy link

martinfrancois commented Nov 10, 2020

Consider adding a unit test which makes a deep copy before running parse, then compare the input to parse with the deep copy from before (checking for equality), to prevent regressions in the future 😃

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a0f3ef4 on juanjoDiaz:fix_unset_v5 into b071eb1 on zemirco:v5.

@knownasilya knownasilya merged commit 6e4ea5e into zemirco:v5 Nov 12, 2020
@martinfrancois
Copy link

Thanks for merging @knownasilya , is there a chance we can have a release soon, so we can get rid of our workaround that's in place for the moment?

@knownasilya
Copy link
Collaborator

Released

@martinfrancois
Copy link

Thanks a lot! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants